Rewrite of 'Adjust correction history' condition #5685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change bench: 840721
|
clang-format 18 needs to be run on this PR. (execution 11935135151 / attempt 1) |
pb00068
changed the title
xu-shawn
reviewed
Nov 21, 2024
| && !(!bestMove && bestValue >= ss->staticEval)) | ||
| if (!ss->inCheck && !(bestMove && pos.capture(bestMove)) | ||
| && ((bestValue < ss->staticEval && bestValue < beta ) // negative correction & no fail high | ||
| || (bestValue > ss->staticEval && bestMove))) // positive correction & no fail low |
There was a problem hiding this comment.
// Do not apply negative correction when failing high
// Do not apply positive correction when failing lowDo you think this might be a clearer rewording of the comments above?
There was a problem hiding this comment.
Thanks, Yes, I like it.
But before changing something I wait for further reactions (maintainers will decide).
There was a problem hiding this comment.
i prefer the initial version, short and concise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current condition is IMO convoluted and hard to understand because of several negations.
Also added 2 comments to make the concept behind the condition better understandable.
No functional change
bench: 840721